Skip to content

Cairo version update + improvements #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Cairo version update + improvements #20

wants to merge 45 commits into from

Conversation

fmkra
Copy link
Member

@fmkra fmkra commented Mar 22, 2024 •
edited
Loading

  • Updated cairo version from 0.7.0 to 2.6.4 and made appropriate changes to be able to compile in this version
  • Refactored MMR append tests to also check data returned by append function
  • Improved MMR append function by implementing algorithm described here
  • RLP decoding improvements from Safe perf #19 Pull Request
  • Other minors improvements (including refactoring loops, using div_rem, etc.)

fmkra and others added 30 commits September 29, 2023 10:00
@fmkra
Add helper function for mmr append
0430d63
@fmkra
Check peaks length in mmr append
a143f6f
@fmkra
Add test for mmr forge peaks
9cb7250
@fmkra
Change utils function from u256 to u32
6c130bd
@fmkra
Add natspec comments
49fde6d
@fmkra
Run scarb fmt
9b64079
@fmkra
Implement trailing_ones helper function
b309c9f
@fmkra
Improve mmr append
a6989df
@fmkra
Remove unnecessary import in test_mmr
e98ef12
@fmkra
Run scarb fmt
ce3e1f2
@tiagofneto
fix words64 to u256 empty words
d9e3148
@fmkra
Implement get_peak_info function
3ced64e
@fmkra
Tests for get_peak_info function
2460417
@fmkra
Fix verify_proof logic
c5af976
@fmkra
Merge branch 'fixes' into improvement/append
a8581d4
@fmkra
Format
01e7d3a
@feltroidprime
use div_rem instead of operators
fa1d030
@feltroidprime
as_u256_le optimisation
d36d653
@feltroidprime
use div_rem in extract_nibbles instead of bitwise ops
5c00047
@feltroidprime
slice_le optimisation
2d8b0ea
@fmkra
Update scarb version
89b5a39
@fmkra
Remove unused variable
0b17101
@fmkra
Refactor tests
11cfdc6
@fmkra
Fmt
3aaed82
@fmkra
Merge branch 'update-cairo' into improvement/append
f41cbc5
@fmkra
Merge branch 'update-cairo' into safe-perf
b5ef6ee
@fmkra
Fix compatibility with 2.6.4
fcf48af
@fmkra
Merge pull request #19 from feltroidprime/safe-perf
5add5cc 
Safe perf
@fmkra
Merge branch 'update-cairo' into improvement/append
1e2bc3f
@fmkra
MMR append change loops to pop from span
c65b8e3
@fmkra fmkra marked this pull request as ready for review May 31, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmkra @tiagofneto @feltroidprime